Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating python support versions #5015

Merged
merged 8 commits into from
Feb 28, 2024
Merged

Updating python support versions #5015

merged 8 commits into from
Feb 28, 2024

Conversation

matthewshaver
Copy link
Contributor

What are you changing in this pull request and why?

Updating the python version support FAQ with the most recent info.

Checklist

Adding or removing pages (delete if not applicable):

  • Add/remove page in website/sidebars.js
  • Provide a unique filename for new pages
  • Add an entry for deleted pages in website/vercel.json
  • Run link testing locally with npm run build to update the links that point to deleted pages

@matthewshaver matthewshaver requested a review from a team as a code owner February 28, 2024 20:50
Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-getdbt-com ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 10:11pm

@github-actions github-actions bot added size: small This change will take 1 to 2 days to address content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs and removed size: small This change will take 1 to 2 days to address labels Feb 28, 2024
@@ -5,26 +5,12 @@ sidebar_label: 'Python version'
id: install-python-compatibility
---

<VersionBlock firstVersion="1.6">
Adapter plugins and their dependencies are not always compatible with the latest version of Python. For example, dbt-snowflake v0.15 is not compatible with Python 3.12, but dbt-snowflake versions 0.20+ are.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aranke Is there a more recent example we can provide here?

@runleonarun
Copy link
Collaborator

@matthewshaver Can you fold your feedback into this PR?

@matthewshaver matthewshaver reopened this Feb 28, 2024
@github-actions github-actions bot added the size: small This change will take 1 to 2 days to address label Feb 28, 2024
Closes #5006

## What are you changing in this pull request and why?

Adding an easier to glance at table for Python <> dbt Core version
compatibility.
## Checklist
- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
so my content adheres to these guidelines.
- [ ] For [docs
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning),
review how to [version a whole
page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
and [version a block of
content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content).
- [ ] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

Adding or removing pages (delete if not applicable):
- [ ] Add/remove page in `website/sidebars.js`
- [ ] Provide a unique filename for new pages
- [ ] Add an entry for deleted pages in `website/vercel.json`
- [ ] Run link testing locally with `npm run build` to update the links
that point to deleted pages
@matthewshaver matthewshaver linked an issue Feb 28, 2024 that may be closed by this pull request
1 task
Copy link
Contributor

@nghi-ly nghi-ly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! left one non-blocking sugg

website/docs/faqs/Core/install-python-compatibility.md Outdated Show resolved Hide resolved
Co-authored-by: Ly Nguyen <107218380+nghi-ly@users.noreply.github.com>
@matthewshaver matthewshaver merged commit 1a0a219 into current Feb 28, 2024
7 checks passed
@matthewshaver matthewshaver deleted the python-versions branch February 28, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content Improvements or additions to content Docs team Authored by the Docs team @dbt Labs February-2024 size: small This change will take 1 to 2 days to address
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Python versions page
3 participants